Release/3.18.0 #477
Closed
Release/3.18.0 #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-identity-profile-preview-update Sdk 2201 add support to fetch the identity profile preview update
Sdk 2238 net create session
Sdk 2245 net retrieve session
* SDK-2252:added net create qr code * SDK-2252:Updated validation rule * SDK-2252:removed net 2.1 support for security issues
* SDK-2257:added net retrieve qr code * SDK-2257:Updated GetQrCode Result * SDK-2257:updated exception type * SDK-2257 updated request types vars
* update versions * Update README.md * change support contact * Update ISSUE_TEMPLATE.md
#458) * SDK-2363 added check for optional attribute, updated tests * SDK-2363 updated test scenarios to match new changes
Bumps [Google.Protobuf](https://github.com/protocolbuffers/protobuf) from 3.21.3 to 3.22.0. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py) - [Commits](protocolbuffers/protobuf@v3.21.3...v3.22.0) --- updated-dependencies: - dependency-name: Google.Protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….Common and Microsoft.CodeAnalysis.CSharp (#460) Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn), [Microsoft.CodeAnalysis.Common](https://github.com/dotnet/roslyn) and [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn). These dependencies needed to be updated together. Updates `Microsoft.CodeAnalysis.CSharp.Workspaces` from 4.2.0 to 4.9.2 - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits) Updates `Microsoft.CodeAnalysis.Common` from 4.2.0 to 4.9.2 - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits) Updates `Microsoft.CodeAnalysis.CSharp` from 4.2.0 to 4.9.2 - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.CSharp.Workspaces dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Microsoft.CodeAnalysis.Common dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Microsoft.CodeAnalysis.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps Microsoft.VisualStudio.Azure.Containers.Tools.Targets from 1.16.1 to 1.20.1. --- updated-dependencies: - dependency-name: Microsoft.VisualStudio.Azure.Containers.Tools.Targets dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* SDK-2264:Added GetShareReceipt and CryptoEngine methods,added models,unit tests, example digitalidentity project, controllers * SDK-2416 added support for advanced identity profile to share v2 (#461) * SDK-2264 updated Newtonsoft.Json 13.0.3
* SDK-2416 updated json generation method * SDK-2416 updated tests for generation method * SDK-2416: added examples for wanted attribute optional parameter
* SDK-2354 added error details and related tests
* SDK-2374 added failure reason info to idv and added tests
* update example session configurations * IN5631 Updated to remove unsupported dotnet versions * IN5631 Updated tests for dotnet version support
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Create qr fix
There was a problem hiding this comment.
Pull Request Overview
This PR (release/3.18.0) upgrades several projects to .NET 6.0 and introduces new optional parameter support for wanted attributes, along with various improvements and adjustments in tests, sample applications, and core DigitalIdentity functionality.
- Updates target frameworks in tests and common libraries to net6.0.
- Adds a new WithOptional method to WantedAttributeBuilder and adjusts WantedAttribute’s Optional property type.
- Updates endpoints and example configurations in DigitalIdentityService and related example projects.
Reviewed Changes
Copilot reviewed 111 out of 135 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/Yoti.Auth.Tests/Yoti.Auth.Tests.csproj | Updated target framework from netcoreapp3.1 to net6.0 |
| test/Yoti.Auth.Tests.Common/Yoti.Auth.Tests.Common.csproj | Updated target framework from netcoreapp2.1 to net6.0 |
| src/Yoti.Auth/Yoti.Auth.csproj | Updated target frameworks and library versions; bumped package version to 3.16.0 |
| src/Yoti.Auth/ShareUrl/Policy/WantedAttributeBuilder.cs | Added new WithOptional method to support an optional flag for wanted attributes |
| src/Yoti.Auth/ShareUrl/Policy/WantedAttribute.cs | Changed Optional property type to bool? and passed through the new optional flag |
| src/Yoti.Auth/DigitalIdentity/DigitalIdentityService.cs | Updated endpoints and minor formatting changes for share session and QR code creation |
| Examples and other project files | Refactored test configurations and example setups to align with the framework updates |
| .WithKeyPair(keyPair) | ||
| .WithBaseUri(apiUrl) | ||
| .WithHeader(yotiAuthId, sdkId) | ||
| .WithEndpoint(string.Format($"/v2/sessions/{0}/qr-codes", sessionId)) |
There was a problem hiding this comment.
The endpoint string is being formatted using an interpolated string with a placeholder {0}. Consider using either string.Format("/v2/sessions/{0}/qr-codes", sessionId) or using string interpolation directly as $"/v2/sessions/{sessionId}/qr-codes" to ensure the sessionId is properly inserted.
Suggested change
| .WithEndpoint(string.Format($"/v2/sessions/{0}/qr-codes", sessionId)) | |
| .WithEndpoint($"/v2/sessions/{sessionId}/qr-codes") |
Copilot uses AI. Check for mistakes.
|
Hello! I'm an engineer at Trinsic working on an integration that needs the functionality that this release will add to the SDK. Is there a time-frame to when will these changes be released? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (release/3.18.0) upgrades several projects to .NET 6.0 and introduces new optional parameter support for wanted attributes, along with various improvements and adjustments in tests, sample applications, and core DigitalIdentity functionality. Added CreateQr Methods.